Improve performance on thread view updating
Mod Version: 1.00, by dwh
This modification is in the archives.
| vB Version: 3.0.7 | Rating:  (1 vote - 5.00 average) |
Installs: 16 |
| Released: 17 Mar 2005 | Last Update: Never | Downloads: 0 |
 Not Supported
|
||
Per Doc Erwin:
http://www.vbulletin.com/forum/showpost.php?p=834208&postcount=18
I'm releasing this here.
I have a suggestion to improve performance although it is for mysql 4.04 and up (I assume at some point a future version of vb will require it).
Requirements: MySQL 4.04
If you have a large forum, run mysql 4.04 and up and want to try this, please report back on your results.
The way updating threads views works right now, (even though putting it in cron improved things,) you are still going through many queries to the thread table, potentially locking it up while updating views.The current code from threadviews.php is:
PHP Code:
With 4.04 you can do a multitable update.
FIRST, create the table ONCE ONLY
PHP Code:
and in the threadviews.php code change it to
PHP Code:
That will reduce the number of queries by however many threads get updated in the cron interval. Additionally, you might be able to skip creating the extra table using subqueries. I haven't gotten around to writing that code yet. If someone wants to add that,mention it in this thread and I'll update the code.
http://www.vbulletin.com/forum/showpost.php?p=834208&postcount=18
I'm releasing this here.
I have a suggestion to improve performance although it is for mysql 4.04 and up (I assume at some point a future version of vb will require it).
Requirements: MySQL 4.04
If you have a large forum, run mysql 4.04 and up and want to try this, please report back on your results.
The way updating threads views works right now, (even though putting it in cron improved things,) you are still going through many queries to the thread table, potentially locking it up while updating views.The current code from threadviews.php is:
PHP Code:
PHP Code:
$threads = $DB_site->query("SELECT threadid , COUNT(*) AS views FROM " . TABLE_PREFIX . "threadviews GROUP BY threadid");
while ($thread = $DB_site->fetch_array($threads))
{
$DB_site->query(
"UPDATE " . TABLE_PREFIX . "thread
SET views = views + " . intval($thread['views']) . "
WHERE threadid = " . intval($thread['threadid'])
);
}
With 4.04 you can do a multitable update.
FIRST, create the table ONCE ONLY
PHP Code:
PHP Code:
CREATE TABLE `threadviewsaggregate` (
`threadid` int(10) NOT NULL default '0',
`views` int(10) NOT NULL default '0',
PRIMARY KEY (`threadid`)
) TYPE=MyISAM;
PHP Code:
PHP Code:
$DB_site->query("INSERT INTO ".TABLE_PREFIX ."threadviewsaggregate SELECT threadid , COUNT(*) AS views FROM " . TABLE_PREFIX . "threadviews GROUP BY threadid");
$DB_site->query("DELETE FROM " . TABLE_PREFIX . "threadviews");
$DB_site->query(
"UPDATE " . TABLE_PREFIX . "thread,". TABLE_PREFIX ."threadviewsaggregate
SET ". TABLE_PREFIX ."thread.views = ". TABLE_PREFIX ."thread.views + ".TABLE_PREFIX."threadviewsaggregate.views
WHERE ". TABLE_PREFIX ."thread.threadid = ". TABLE_PREFIX ."threadviewsaggregate.threadid");
$DB_site->query("DELETE FROM ". TABLE_PREFIX ."threadviewsaggregate");
That will reduce the number of queries by however many threads get updated in the cron interval. Additionally, you might be able to skip creating the extra table using subqueries. I haven't gotten around to writing that code yet. If someone wants to add that,mention it in this thread and I'll update the code.
Download
No files for download.